Layout fixes

[blackbox87]

What is it?

• Bug fix (user facing)
• Feature (user facing)
• Code base improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Fixes various layout issues on devices using Android 4.1
• Correct the vector drawable used after #3271

Agreement

• I carefully read the contribution guidelines and agree to them.

[blackbox87]

@friendlyanon @TobiGr Is there a reason this pull request didn't get merged into v0.19.8?

Currently you're using stuff like layout_marginStart, but because that attribute doesn't exist in API 16 you don't get the expected look. Android Studio would normally warn you about this and fail to compile the app, but for some reason NewPipe Legacy is setup to ignore these warnings.

[MD77MD]

is this related to my problem #18 (comment)

[TobiGr]

Are these changes necessary, because Android <= 4.4 does not know the ...Start and ...End layout params? If this is the case, I'd like to draw your attention to TeamNewPipe/NewPipe#3488 which removes the hard-coded left and right layout params for better RTL support.

So if this is the problem, this looks good to me. However @friendlyanon takes care of the legacy repository and should therefore merge / review this PR.

[blackbox87]

Are these changes necessary, because Android <= 4.4 does not know the ...Start and ...End layout params?

Yes. Here's a quick example of what NewPipe Legacy looks like before and after applying the changes.

If this is the case, I'd like to draw your attention to TeamNewPipe/NewPipe#3488 which removes the hard-coded left and right layout params for better RTL support.

That pull request will be a problem for NewPipe Legacy because they've replaced the left/right attributes with start/end and they've also used getLayoutDirection() and android:supportsRtl, which are only available in Android 4.2 or newer.

[blackbox87]

@TobiGr By the way, one of the fixes in this pull request should also be copied to NewPipe.

Issues like this keep slipping through because of how NewPipe is configured to ignore most warnings. In this case the drawable doesn't exist, which isn't a critical issue, but it is when you're trying to use methods that don't exist on your minimum API level.