This repository has been archived by the owner on Jul 5, 2022. It is now read-only.
Improve energy efficiency by applying Dynamic Retry Delay Energy Pattern + Cache Energy Pattern #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make a PR to TeamNewPipe/NewPipe. PRs to this repo should only contain fixes specifically for older devices. |
TobiGr
reviewed
Jul 23, 2020
There was a problem hiding this comment.
Thank you for your contribution!
As wb9688 already said, this repository is mostly for applying fixes for devices with Android versions < 4.4. So please open the PR in the repo for the regular app. Changes will be merged into this repo.
In general: Please add more comments to the code so one can easily read and understand the code without looking at the PR description.
| @@ -25,18 +22,28 @@ | |||
| private static TLSSocketFactoryCompat instance = null; | |||
|
|
|||
| private SSLSocketFactory internalSSLSocketFactory; | |||
|
|
|||
There was a problem hiding this comment.
Please remove the added white spaces.
| @@ -745,6 +751,60 @@ public void onDestroy() { | |||
| .setContentText( | |||
| getString(R.string.preferred_player_fetcher_notification_message)); | |||
| } | |||
|
|
|||
| boolean checkNetwork() { | |||
There was a problem hiding this comment.
Please use a more descriptive method name and add the access modifier to the method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the energy efficiency of SecondScreen by applying the Dynamic Retry Delay Energy Pattern and the Cache Energy Pattern for mobile applications.
The energy pattern was applied in RouterActivity.java and AndroidManifest.xml (for the Dynamic Retry Delay Energy Pattern) and TLSSocketFactoryCompat.java (for the Cache Energy Pattern). The general idea for the first one is to avoid accessing an internet connection if the connection is down . In particular, a class NetworkStateReceiver will be created in the java file that checks for an internet connection. The general idea for the second one is to avoid performing unnecessary operations by using cache mechanisms. In particular, setting the cache size to have no limit.