Skip to content
This repository has been archived by the owner on Jul 5, 2022. It is now read-only.

Update version codes of fastlane changelogs #36

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Jul 29, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

To display changelogs in F-Droid and on their website, the changelog files need to be named like this: version_code.txt
As you use different version codes, you should rename the changelog files and create new ones, when there are additional releases. I am currently working on an improved download section on our website and added NewPipe legacy to it. I need to get the changelog info from GitHub to display it on the website by using our web API. I'd also like to integrate viewing changelogs in the app later.

Fixes the following issue(s)

  • Fix crash and empyt changelog in web API

Testing apk

Not needed as only metadata is changed.

Agreement

To display changelogs in F-Droid and on their website, the changelog files need to be named like this: `version_code.txt`
As the version codes in the legacy repository are different to these from the main NewPipe repository, rename the latest changelog file for version 0.19.8. This will not have an effect on F-Droid yet, becuase the commit has not been pushed to the 0.19.8 tag.
@wb9688
Copy link
Contributor

wb9688 commented Jul 30, 2020

Don't forget how certain versions don't have Legacy versions, so the content of the changelog should also be changed.

@TobiGr
Copy link
Member Author

TobiGr commented Jul 30, 2020

Correct, but I don't think that this is necessary for old releases. I've set the number of processed changelogs to 1 for now and will increase it once there are more correctly named changelogs.

@TobiGr TobiGr merged commit 1b5f221 into master Jul 30, 2020
@TobiGr TobiGr deleted the version_codes branch July 30, 2020 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants