Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/utf8_encode_deprication - Fix utf8_encode deprecation #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdalasif
Copy link

Fix utf8_encode deprecation notice for php 8.2+

@abdalasif abdalasif force-pushed the fix/utf8_encode_deprication branch from 6e58786 to 96dac5b Compare July 29, 2024 13:17
@abdalasif
Copy link
Author

@adohertyTS any chance this can be reviewed?

@adohertyTS
Copy link
Contributor

hi @abdalasif , I've created a ticket for this internally here at Telesign. Could you tell me more about the impact this is having on you? That will help me prioritize the issue against our other work.

@abdalasif
Copy link
Author

@adohertyTS thank you, this throws a warning on authentication as utf8_encode is used which is deprecated

@ralfzeit
Copy link

ralfzeit commented Oct 9, 2024

Hi @adohertyTS , when you can expect to apply these changes?

@adohertyTS
Copy link
Contributor

Hi @ralfzeit , we are in-progress working on this issue, and if all goes well I would tentatively expect this issue to be fixed by Oct 31. Note that we do not currently accept external pull requests, so our developers would address this issue with a new, internal pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants