[auth][test] Add unit test basis for auth service #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-harding
approved these changes
Mar 6, 2020
Lewiky
approved these changes
Mar 6, 2020
willjvsmith
approved these changes
Mar 6, 2020
| @@ -4,8 +4,8 @@ go 1.13 | |||
|
|
|||
| require ( | |||
| github.com/asaskevich/govalidator v0.0.0-20200108200545-475eaeb16496 | |||
| github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect | |||
| github.com/dgrijalva/jwt-go v3.2.0+incompatible | |||
There was a problem hiding this comment.
What's the incompatible referring to?
There was a problem hiding this comment.
dgrijalva/jwt-go#294 Looks like it's a go mod thing, where jwt-go doesn't fully support modules in v3, but will do in v4. Looks like it's in preview for now, but we can upgrade if/when they release, although they mention will be some breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow such verbosity.
Add all the boilerplate we need to write tests for the auth service.