Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(publish): use fat-aar-android to build aar #2813

Merged
merged 8 commits into from
Jan 10, 2023
Merged

feat(publish): use fat-aar-android to build aar #2813

merged 8 commits into from
Jan 10, 2023

Conversation

siguangli
Copy link
Collaborator

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@hippy-service
Copy link

hippy-service bot commented Dec 16, 2022

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

medns
medns requested changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@medns medns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contact me

@hippy-service
Copy link

hippy-service bot commented Dec 16, 2022

Hi, @siguangli, I noticed that our reviewers requested changes to this pull request.
When you're done, click the Re-request review button in the right sidebar(shown below) to notify the reviewer.
Re-request review button in the right sidebar

@github-actions github-actions bot added size: l Denotes a PR that changes 500-999 lines and removed size: m Denotes a PR that changes 100-499 lines labels Dec 20, 2022
@siguangli siguangli requested a review from medns December 20, 2022 12:04
medns
medns requested changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@medns medns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changes

zoomchan-cxj
zoomchan-cxj previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@zoomchan-cxj zoomchan-cxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siguangli siguangli requested a review from medns January 5, 2023 04:12
medns
medns requested changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@medns medns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to static gradle deps

@siguangli siguangli requested a review from medns January 9, 2023 07:04
medns
medns approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@medns medns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medns medns added the action(squash-merge) Squash and merge action label Jan 9, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) January 9, 2023 09:16
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jan 9, 2023
@siguangli siguangli added the action(squash-merge) Squash and merge action label Jan 10, 2023
@medns medns disabled auto-merge January 10, 2023 02:46
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jan 10, 2023
@hippy-actions
Copy link

hippy-actions bot commented Jan 10, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@hippy-actions hippy-actions bot added the action(squash-merge): failed Squash and merge action execution failed label Jan 10, 2023
@medns medns added the action(squash-merge) Squash and merge action label Jan 10, 2023
@hippy-actions hippy-actions bot removed the action(squash-merge): failed Squash and merge action execution failed label Jan 10, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) January 10, 2023 02:49
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Jan 10, 2023
@hippy-actions hippy-actions bot merged commit dae789f into Tencent:v3.0-dev Jan 10, 2023
@siguangli siguangli deleted the feat/fat-aar-android branch July 10, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medns medns medns approved these changes

@zoomchan-cxj zoomchan-cxj zoomchan-cxj left review comments

Assignees
No one assigned
Labels
build: gradle doc: example framework: android renderer: native size: l Denotes a PR that changes 500-999 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siguangli @medns @zoomchan-cxj @siguangli2018