Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): refactoring WaterfallView #3809

Merged
merged 6 commits into from
Apr 8, 2024
Merged

feat(android): refactoring WaterfallView #3809

merged 6 commits into from
Apr 8, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Apr 7, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@siguangli siguangli added the action(squash-merge) Squash and merge action label Apr 7, 2024
@hippy-actions Hippy Actions
Copy link

hippy-actions bot commented Apr 7, 2024

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@siguangli

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Apr 7, 2024
iPel
iPel approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@siguangli siguangli merged commit 8dad9f2 into Tencent:main Apr 8, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

@zealotchen0 zealotchen0 zealotchen0 approved these changes

@lvfen lvfen Awaiting requested review from lvfen lvfen is a code owner

@henryjin0511 henryjin0511 Awaiting requested review from henryjin0511 henryjin0511 is a code owner

Assignees
No one assigned
Labels
action(squash-merge): failed Squash and merge action execution failed doc: example doc: pages driver: js framework: voltron renderer: native size: xl Denotes a PR that changes 1000+ lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siguangli @iPel @zealotchen0 @siguangli2018