feat(ios): update ViewPager's pageIndex automatically after data changes #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the issue of missing onPageSelected callbacks upon first entry; The logic for automatic updates keep same with Android, as follows 1. If the previous item only changes its location, update the current location and keep the current item displayed. 2. If the previous item does not exist, do not adjust the position, but keep the current position in the valid range (that is, 0 ~ count-1).
this is a minor fix for feat 'pageIndex of ViewPager auto update after data changes'
github-actions
bot
added
renderer: native
size: s
|
Hi, @wwwcg. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
wwwcg
added a commit
to wwwcg/Hippy
that referenced
this pull request
May 16, 2024
…ges (Tencent#3857) * feat(ios): pageIndex of ViewPager auto update after data changes Also fixed the issue of missing onPageSelected callbacks upon first entry; The logic for automatic updates keep same with Android, as follows 1. If the previous item only changes its location, update the current location and keep the current item displayed. 2. If the previous item does not exist, do not adjust the position, but keep the current position in the valid range (that is, 0 ~ count-1). * fix(ios): auto-update of page index may lag by one frame in view pager this is a minor fix for feat 'pageIndex of ViewPager auto update after data changes'
wwwcg
added a commit
that referenced
this pull request
May 20, 2024
…ges (#3857) * feat(ios): pageIndex of ViewPager auto update after data changes Also fixed the issue of missing onPageSelected callbacks upon first entry; The logic for automatic updates keep same with Android, as follows 1. If the previous item only changes its location, update the current location and keep the current item displayed. 2. If the previous item does not exist, do not adjust the position, but keep the current position in the valid range (that is, 0 ~ count-1). * fix(ios): auto-update of page index may lag by one frame in view pager this is a minor fix for feat 'pageIndex of ViewPager auto update after data changes'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: