Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(button): resolve few problems #212

Merged
merged 1 commit into from
Mar 7, 2022
Merged

refactor(button): resolve few problems #212

merged 1 commit into from
Mar 7, 2022

Conversation

anlyyao
Copy link
Collaborator

@anlyyao anlyyao commented Mar 4, 2022 •
edited by LeeJim
Loading

Breaking Changes

Button：

  • 重构 shape 的实现，新增支持 rectangle、circle 类型
  • 修复 shape = round 样式不对的问题
  • 支持纯图标按钮

resolve #102 #108

@anlyyao anlyyao linked an issue Mar 4, 2022 that may be closed by this pull request
Button 组件支持纯图标按钮 #108
Closed
@anlyyao anlyyao requested a review from LeeJim March 4, 2022 04:03
@LeeJim LeeJim changed the title fix(button): 修复round无效,支持icon按钮.shape支持rectangle(默认)、square、round、circle fix(button): resolve shape problem & support icon-only button Mar 4, 2022
LeeJim
LeeJim requested changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要记得同步修改文档

example/pages/button/button.wxml Outdated Show resolved Hide resolved
src/button/button.less Outdated Show resolved Hide resolved
src/button/button.less Outdated Show resolved Hide resolved
src/button/button.ts Outdated Show resolved Hide resolved
LeeJim
LeeJim requested changes Mar 4, 2022
View reviewed changes
src/button/README.md Outdated Show resolved Hide resolved
src/button/README.md Outdated Show resolved Hide resolved
example/pages/button/button.wxml Show resolved Hide resolved
src/button/button.less Outdated Show resolved Hide resolved
@LeeJim LeeJim changed the title fix(button): resolve shape problem & support icon-only button refactor(button): resolve shape problem & support icon-only button Mar 7, 2022
@anlyyao anlyyao changed the title refactor(button): resolve shape problem & support icon-only button fix(button): shape新增rectangle和circle&&修复shape中square和round失效问题&&新增支持纯图标按钮 Mar 7, 2022
@anlyyao anlyyao changed the title fix(button): shape新增rectangle和circle&&修复shape中square和round失效问题&&新增支持纯图标按钮 fix(button): shape新增rectangle和circle&&修复shape中square和round失效问题&&新增支持纯图标按钮&&block实现改用display:block Mar 7, 2022
@LeeJim LeeJim changed the title fix(button): shape新增rectangle和circle&&修复shape中square和round失效问题&&新增支持纯图标按钮&&block实现改用display:block refactor(button): resolve few problems Mar 7, 2022
@LeeJim LeeJim merged commit bca63a4 into develop Mar 7, 2022
@LeeJim LeeJim deleted the fix/button branch March 7, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeJim LeeJim LeeJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button 组件支持纯图标按钮 设置圆角按钮无效
2 participants
@anlyyao @LeeJim