Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:记录image组件传入的src防止在src相同时重复更新 #221

Merged
merged 1 commit into from
Mar 7, 2022
Merged

fix:记录image组件传入的src防止在src相同时重复更新 #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/image/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export default class Image extends SuperComponent {
classPrefix: name,
};

preSrc = ''; // 保留上一次的src,防止在src相同时重复update

lifetimes = {
attached(this: Image) {
this.update();
Expand All @@ -29,6 +31,7 @@ export default class Image extends SuperComponent {

observers = {
src() {
if (this.preSrc === this.properties.src) return;
this.update();
},
};
Expand Down Expand Up @@ -74,6 +77,7 @@ export default class Image extends SuperComponent {

update() {
const { src } = this.properties as any;
this.preSrc = src;
if (!src) {
// 链接为空时直接触发加载失败
this.onLoadError({ errMsg: '图片链接为空' });
Expand Down