Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): 修复在 Skyline 模式下组件不能正常使用的问题 #2788

Merged
merged 1 commit into from
May 23, 2024

Conversation

narukeu
Copy link
Contributor

@narukeu narukeu commented May 21, 2024

fix the issue with the tabs component under Skyline

fix #2786

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#2786

💡 需求背景和解决方案

  • tabs 组件依赖小程序内置的 scroll-view 组件,而在 Skyline 渲染模式下 scroll-view 组件需要增加 type 属性才可以正常运作, 这里加上了 type="list"
  • 关于 scroll-view 在 skyline 的属性参见:'说明文档'

📝 更新日志

  • fix(Tabs): 修复在 Skyline 模式下组件不能正常使用的问题 ...

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

fix the issue with the tabs component under Skyline

fix Tencent#2786
@jarmywang jarmywang merged commit 68d2e3d into Tencent:develop May 23, 2024
4 checks passed
@narukeu narukeu deleted the fix-tab-skyline branch May 24, 2024 16:00
@github-actions github-actions bot mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tabs] 不支持 skyline
2 participants