Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slider): update slider demo padding #2807

Merged
merged 3 commits into from
May 28, 2024

Conversation

novlan1
Copy link
Contributor

@novlan1 novlan1 commented May 28, 2024

fix #2795

  • 更新示例

@ArcticFoxPro
Copy link
Contributor

ArcticFoxPro commented May 28, 2024

您好,我看到这里似乎还有可以优化的点,因此打扰一下。

  1. PR 标题“update”打错了,打成了“upadte”
  2. 似乎带刻度和不带刻度的滑动选择器的左右端侧没有对齐,1.4.0 Release 是对齐了的。

Screenshot_2024-05-28-13-31-41-551_com.tencent.mm-edit.jpg

IMG_20240528_134830.jpg

第二张图是 1.4.0 的 TDesign Demo,虽然似乎带刻度的看起来没有和不带刻度的对齐,但是当把滑动控件拉到末端时,实际上是对齐的。

IMG_20240528_134939.jpg

@novlan1 novlan1 changed the title chore(slider): upadte slider demo padding chore(slider): update slider demo padding May 28, 2024
@novlan1
Copy link
Contributor Author

novlan1 commented May 28, 2024

您好,我看到这里似乎还有可以优化的点,因此打扰一下。

  1. PR 标题“update”打错了,打成了“upadte”
  2. 似乎带刻度和不带刻度的滑动选择器的左右端侧没有对齐,1.4.0 Release 是对齐了的。

Screenshot_2024-05-28-13-31-41-551_com.tencent.mm-edit.jpg

IMG_20240528_134830.jpg

第二张图是 1.4.0 的 TDesign Demo,虽然似乎带刻度的看起来没有和不带刻度的对齐,但是当把滑动控件拉到末端时,实际上是对齐的。

IMG_20240528_134939.jpg

已解决

@anlyyao anlyyao merged commit 3c0af32 into Tencent:develop May 28, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants