Docs/progress 修复首次进入时与设置的stroke-width的延迟显示和兼容性问题 #3133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxinhai
requested review from
anlyyao,
jarmywang,
jin0209 and
betavs
as code owners
anlyyao
reviewed
Sep 10, 2024
|
@huxinhai 这个场景 方便提供录屏👀👀吗 |
anlyyao
reviewed
Sep 10, 2024
src/progress/progress.wxml
Outdated
| @@ -80,7 +80,7 @@ | |||
| > | |||
| <view | |||
| class="{{classPrefix}}__canvas--inner {{prefix}}-class-bar" | |||
| style="{{innerDiameter? 'width:'+ innerDiameter*2 + 'rpx;' + 'height:'+ innerDiameter*2 + 'rpx;': ''}}" | |||
| style="{{strokeCircleWidth? '--td-progress-stroke-circle-width:'+ strokeCircleWidth : ''}}" | |||
There was a problem hiding this comment.
style="{{heightBar? '--td-progress-stroke-circle-width:' + heightBar + 'px': ''}}"
There was a problem hiding this comment.
getInnerDiameter() 可以整段移除了
|
改完之后要更新快照文件 |
|
/update-snapshot |
1 similar comment
|
/update-snapshot |
16 tasks
|
Duplicate of #3139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
背景： 在使用progress组件时 当小程序首次进来的时候 会出现外部设置了stroke-width 但是在最开始的时候还是能看到组件本身的默认值 要等一小会才会更新视图 虽然说理论上都要先做单位转换， 直接*2 除了375的屏幕，其他屏幕下会有出入 #但是我觉得起码这样可以先解决大问题😄😄
📝 更新日志
fix(Progress): 修复环形进度条首次加载时，
strokeWidth线宽延迟显示的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单