Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): correct classname #56

Merged
merged 1 commit into from
Dec 29, 2021
Merged

fix(radio): correct classname #56

merged 1 commit into from
Dec 29, 2021

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented Dec 28, 2021

Radio:纠正 classname

</view>
<!-- 文本内容 -->
<view
class="{{classPrefix}}__content {{disabled ? classPrefix + '-is-disabled-context' : ''}}"
class="{{classPrefix}}__content {{disabled ? classPrefix + '__content--disabled' : ''}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

关于disabled是用 {{prefix}}-is-disabled,还是说用这种状态来控制较好?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都是 OK 的,我的理解是一般直接用 modifier,除非要复用才用单独的状态类

Copy link
Collaborator

@jin0209 jin0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jin0209 jin0209 merged commit 75af8c1 into develop Dec 29, 2021
@jin0209 jin0209 deleted the fix/radio/classname branch December 29, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants