Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Tencent / tdesign-mobile-react Public

Notifications You must be signed in to change notification settings
Fork 65
Star 59

Code
Issues 43
Pull requests 24
Discussions
Actions
Projects 1
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tag): support children props #445

Merged

anlyyao merged 1 commit into Tencent:develop from taninsist:feat/tag

Aug 14, 2024

Merged

feat(Tag): support children props #445

anlyyao merged 1 commit into Tencent:develop from taninsist:feat/tag

Aug 14, 2024

Conversation 31 Commits 1 Checks 6 Files changed

Conversation

Copy link

Contributor

taninsist commented Aug 8, 2024 •

edited by anlyyao

Loading

🤔 这个 PR 的性质是？

日常 bug 修复
新特性提交
文档改进
演示代码改进
组件样式/交互改进
CI/CD 改进
重构
代码风格优化
测试用例
分支合并
其他

🔗 相关 Issue

fix #411

相关PR
Tencent/tdesign-common#1864
TDesignOteam/tdesign-api#363

💡 需求背景和解决方案

API功能对齐Mobile Vue端
DOM 结构对齐小程序端
改用 V2文件夹下样式
官网示例代码&&演示示例对齐新视觉稿

📝 更新日志

feat(Tag): 新增 children 属性
feat(CheckTag): 新增 variant 属性

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
Changelog 已提供或无须提供

Sorry, something went wrong.

All reactions

taninsist requested review from anlyyao, ZWkang and jarmywang as code owners

August 8, 2024 02:54

Copy link

Contributor

github-actions bot commented Aug 8, 2024 •

edited

Loading

All reactions

Sorry, something went wrong.

taninsist force-pushed the feat/tag branch from 55ea60a to 8dd010e Compare

August 8, 2024 05:50

HaixingOoO reviewed

View reviewed changes

src/tag/CheckTag.tsx Outdated Show resolved Hide resolved

HaixingOoO reviewed

View reviewed changes

src/tag/CheckTag.tsx Outdated Show resolved Hide resolved

HaixingOoO reviewed

View reviewed changes

src/tag/CheckTag.tsx Outdated Show resolved Hide resolved

HaixingOoO reviewed

View reviewed changes

Copy link

Collaborator

HaixingOoO left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成memo统一吧，然后forwardRef<refProps,checkTagProps>这样写类型就好了

Sorry, something went wrong.

All reactions

HaixingOoO reviewed

View reviewed changes

src/tag/Tag.tsx Outdated Show resolved Hide resolved

HaixingOoO reviewed

View reviewed changes

Copy link

Collaborator

HaixingOoO left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Tencent/tdesign-react/blob/develop/src/_util/parseTNode.ts

可以加一个这文件的，然后渲染一些content/children，后面()=>children也可以渐进式支持

Sorry, something went wrong.

All reactions

Copy link

Collaborator

HaixingOoO commented Aug 8, 2024 •

edited

Loading

然后除了style文件夹的引入样式用js，其他文件都用ts/tsx,example文件夹下的文件也要改成tsx

All reactions

Sorry, something went wrong.

taninsist force-pushed the feat/tag branch from 827f207 to 7d233ea Compare

August 9, 2024 13:05

HaixingOoO reviewed

View reviewed changes

src/tag/Tag.tsx Outdated Show resolved Hide resolved

liweijie0812 reviewed

View reviewed changes

.xac/project.yaml Outdated Show resolved Hide resolved

HaixingOoO reviewed

View reviewed changes

src/tag/CheckTag.tsx Outdated Show resolved Hide resolved

Copy link

Collaborator

HaixingOoO commented Aug 12, 2024

src/_util/parseTNode.ts有人加上去了，你可能要合并一下develop分支然后解决一下snap，没啥问题了
@anlyyao 大佬，这个你看看，没问题就可以合并了😀

anlyyao and taninsist reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Copy link

Collaborator

anlyyao commented Aug 13, 2024 •

edited

Loading

@taninsist rebase dev 处理下冲突、更新csr和ssr快照、邮箱换个人的

All reactions

Sorry, something went wrong.

taninsist force-pushed the feat/tag branch 3 times, most recently from 08c83af to 1f1c85e Compare

August 14, 2024 02:20

anlyyao reviewed

View reviewed changes

src/tag/CheckTag.tsx Outdated Show resolved Hide resolved

src/tag/CheckTag.tsx Outdated Show resolved Hide resolved

anlyyao reviewed

View reviewed changes

src/_util/parseTNode.ts Outdated Show resolved Hide resolved

taninsist force-pushed the feat/tag branch from a63c281 to 76de3e9 Compare

August 14, 2024 04:38


          feat(tag): 对齐mobile-vue

66c56cc

taninsist force-pushed the feat/tag branch from 76de3e9 to 66c56cc Compare

August 14, 2024 05:18

anlyyao approved these changes

View reviewed changes

anlyyao changed the title ~~Feat/tag~~ feat(Tag): complete refactoring

anlyyao changed the title ~~feat(Tag): complete refactoring~~ feat(Tag): support children props

anlyyao merged commit 862c5d5 into Tencent:develop

6 checks passed

github-actions bot mentioned this pull request

chore: publish v0.4.0 #466

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

liweijie0812 liweijie0812 left review comments

HaixingOoO HaixingOoO left review comments

anlyyao anlyyao approved these changes

ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

jarmywang Awaiting requested review from jarmywang jarmywang is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

【Tag组件升级】任务单

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.