Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] 关闭弹窗口 body 锁定样式未正确移除 #484

Closed
leeenx opened this issue Mar 15, 2022 · 4 comments · Fixed by #485
Closed

[Dialog] 关闭弹窗口 body 锁定样式未正确移除 #484

leeenx opened this issue Mar 15, 2022 · 4 comments · Fixed by #485
Assignees
@honkinglin
Labels
🐞 bug Something isn't working

Comments

@leeenx
Copy link

leeenx commented Mar 15, 2022 •
edited
Loading

tdesign-react 版本

0.26.0

重现链接

No response

重现步骤

DialogPlugin 在弹窗的时候会向 body 插入一段 style 样式（overflow: hidden），然而在关闭弹窗的时候并没有回收这段代码，导致页面无法滚去。

期望结果

关闭弹窗后，body 上的内联样式恢复到原来的样子 。

实际结果

关闭弹窗后后，body 上仍然保留「overflow: hidden」

框架版本

React17.0.2

浏览器版本

99.0.4844.51

系统版本

MacOS(10.15.7)

Node版本

10.16.0

补充说明

No response
@github-actions
Copy link
Contributor

👋 @leeenx，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@honkinglin honkinglin added the 🐞 bug Something isn't working label Mar 15, 2022
@honkinglin honkinglin changed the title [组件名称] 描述问题的标题 [Dialog] 关闭弹窗口 body 锁定样式未正确移除 Mar 15, 2022
@github-actions
Copy link
Contributor

♥️ 有劳 @ldwonday @HQ-Lin @psaren 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @leeenx 。

@honkinglin
Copy link
Collaborator

收到，今天会处理好发个版本

psaren added a commit to psaren/tdesign-react that referenced this issue Mar 15, 2022
@psaren
fix(dialog): 修复DialogPlugin关闭后滚动问题
fc36aa0 
修复DialogPlugin关闭后滚动问题

fix Tencent#484
@psaren psaren mentioned this issue Mar 15, 2022
Merged
16 tasks
@honkinglin
Copy link
Collaborator

0.27.2 fixed

uyarn pushed a commit that referenced this issue Apr 18, 2022
@psaren
fix(dialog): 修复DialogPlugin关闭后滚动问题
3d00b89 
修复DialogPlugin关闭后滚动问题

fix #484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@honkinglin honkinglin

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dialog): 修复DialogPlugin关闭后滚动问题 psaren/tdesign-react
2 participants
@leeenx @honkinglin