Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 新增 rate组件 #1014

Merged
merged 11 commits into from
Jul 29, 2022
Merged

feat: 新增 rate组件 #1014

merged 11 commits into from
Jul 29, 2022

Conversation

RedDevi1s
Copy link
Contributor

@RedDevi1s RedDevi1s commented Jun 30, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

feat: 新增 rate组件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@RedDevi1s RedDevi1s marked this pull request as ready for review June 30, 2022 08:18
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

完成

@honkinglin
Copy link
Collaborator

ci 全挂
1.更改提交邮箱不要用tencent
2.更新snapshot:npm run test:update

@honkinglin
Copy link
Collaborator

snapshot 要更新一下
执行 npm run test:update

@RedDevi1s RedDevi1s force-pushed the feat/rate branch 2 times, most recently from c9c47a9 to 3591ce8 Compare July 6, 2022 03:12
src/rate/README.md Outdated Show resolved Hide resolved
src/rate/Rate.tsx Outdated Show resolved Hide resolved
src/rate/Rate.tsx Outdated Show resolved Hide resolved
@honkinglin
Copy link
Collaborator

咋感觉hover 动效这么生硬呢。是不是没有加transition

@RedDevi1s
Copy link
Contributor Author

transition

通过transform实现的。后面补一个transition

src/rate/_example/status.jsx Outdated Show resolved Hide resolved
src/rate/Rate.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1014 (5501b3f) into develop (7b04365) will increase coverage by 0.01%.
The diff coverage is 57.42%.

@@             Coverage Diff             @@
##           develop    #1014      +/-   ##
===========================================
+ Coverage    60.40%   60.41%   +0.01%     
===========================================
  Files          937      962      +25     
  Lines        16498    16826     +328     
  Branches      3743     3856     +113     
===========================================
+ Hits          9966    10166     +200     
- Misses        6532     6660     +128     
Impacted Files Coverage Δ
src/_util/copyText.ts 0.00% <0.00%> (ø)
src/_util/dom.ts 42.59% <ø> (ø)
src/_util/helper.ts 41.07% <ø> (ø)
src/_util/insertCSS.ts 0.00% <ø> (ø)
src/_util/number.ts 33.33% <ø> (ø)
src/_util/setStyle.ts 0.00% <ø> (ø)
src/_util/useDialogEsc.ts 46.66% <ø> (ø)
src/_util/useDragSorter.tsx 25.45% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/anchor/Anchor.tsx 81.33% <ø> (ø)
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da6aa5c...5501b3f. Read the comment docs.

@Wen1kang
Copy link

建议桌面端评分默认是24px的大小,20px相对来说小了点
image

@Wen1kang
Copy link

貌似整个rate的div尺寸有问题呀,整个div大小却到了23高度,而且是居左上对齐。16/20/24大小都是如此
设计应该是贴边的
image
image

@Wen1kang
Copy link

放大效果需要加上动效
image

@Wen1kang
Copy link

Wen1kang commented Jul 12, 2022

hover后,星星变灰要加过渡动效,同时灰色星星变成黄色也要加上过渡动效
image

@Wen1kang
Copy link

半选应该是有灰色底色的,但不见了,半选也要有过渡动效
image
image

@Wen1kang
Copy link

Wen1kang commented Jul 12, 2022

所有的尺寸大小margin应该是4px,而不是6px
image

@Wen1kang
Copy link

Wen1kang commented Jul 12, 2022

在原来基础上,建议增加颜色的hover态,用来区分已选星星,再次点击效果,hover颜色叠加上rgba(0, 0, 0, 0.1)和过渡动画效果,保证暗黑模式和自定义颜色场景可以复用,可以参考codepen
image
https://codepen.io/knyttneve/pen/EBNqPN

@honkinglin
Copy link
Collaborator

在原来基础上,建议增加颜色的hover态,用来区分已选星星,再次点击效果,hover颜色叠加上rgba(0, 0, 0, 0.1)和过渡动画效果,保证暗黑模式和自定义颜色场景可以复用,可以参考codepen image https://codepen.io/knyttneve/pen/EBNqPN

我先合并了,周末我来改下

@honkinglin honkinglin merged commit ecd8082 into Tencent:develop Jul 29, 2022
@github-actions github-actions bot mentioned this pull request Aug 1, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants