Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(tree): inherit props status while changing the data #1168

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

CodingOnStar
Copy link
Contributor

"fix #1140"

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1140

💡 需求背景和解决方案

1、更新tree组件的data时,需要保持展开、高亮及check选中的状态
问题还原链接
2、更改了tree组件useStore中的hook
3、实现的改动:
截屏2022-07-25 16 23 02

📝 更新日志

-fix(Tree):更改data、expanded、actived或checked选项时,会保留原始的状态

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1168 (9ef9525) into develop (c4c5d1d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1168      +/-   ##
===========================================
- Coverage    60.18%   60.15%   -0.03%     
===========================================
  Files          959      959              
  Lines        16979    16985       +6     
  Branches      3906     3906              
===========================================
  Hits         10218    10218              
- Misses        6761     6767       +6     
Impacted Files Coverage Δ
src/tree/useStore.ts 56.25% <0.00%> (-5.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51055e5...9ef9525. Read the comment docs.

@honkinglin honkinglin merged commit 053eafb into Tencent:develop Jul 26, 2022
@github-actions github-actions bot mentioned this pull request Aug 1, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tree] data 数据更新后,expanded、actived 等失效
3 participants