Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cascader value check #1170

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

PengYYYYY
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Cascader): 修复在异步获取 option 的情况下,参数校验导致用户行为异常
  • fix(Input):修复 autoWidth 情况下在 dialog 内显示不全

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #1170 (3cc7344) into develop (c4c5d1d) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop    #1170      +/-   ##
===========================================
- Coverage    60.18%   60.16%   -0.02%     
===========================================
  Files          959      959              
  Lines        16979    16984       +5     
  Branches      3906     3905       -1     
===========================================
  Hits         10218    10218              
- Misses        6761     6766       +5     
Impacted Files Coverage Δ
src/cascader/core/helper.ts 92.85% <66.66%> (+3.20%) ⬆️
src/input/Input.tsx 86.40% <100.00%> (-0.70%) ⬇️
src/tree/useStore.ts 56.25% <0.00%> (-5.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51055e5...3cc7344. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

完成

@honkinglin honkinglin merged commit 79f55c3 into Tencent:develop Jul 26, 2022
@honkinglin
Copy link
Collaborator

re #1091

@honkinglin honkinglin mentioned this pull request Jul 27, 2022
16 tasks
@github-actions github-actions bot mentioned this pull request Aug 1, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants