Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Upload): 修复 onRemove 失效问题 #1245

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Aug 8, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Upload): 修复 onRemove 失效问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1245 (e0725ee) into develop (ca9bc02) will decrease coverage by 0.40%.
The diff coverage is 41.71%.

@@             Coverage Diff             @@
##           develop    #1245      +/-   ##
===========================================
- Coverage    60.29%   59.89%   -0.41%     
===========================================
  Files          969      992      +23     
  Lines        17151    17513     +362     
  Branches      3945     4011      +66     
===========================================
+ Hits         10342    10489     +147     
- Misses        6809     7024     +215     
Impacted Files Coverage Δ
src/affix/_example/container.jsx 85.71% <ø> (-0.96%) ⬇️
src/badge/_example/custom.jsx 100.00% <ø> (ø)
src/button/_example/base.tsx 100.00% <ø> (ø)
src/form/hooks/useInstance.tsx 48.80% <0.00%> (ø)
src/select/_example/custom-options.jsx 88.88% <ø> (ø)
src/upload/upload.tsx 27.60% <0.00%> (-0.12%) ⬇️
src/image-viewer/hooks/usePosition.ts 2.63% <2.63%> (ø)
src/image-viewer/utils.ts 5.26% <5.26%> (ø)
src/image-viewer/hooks/useScale.ts 6.25% <6.25%> (ø)
src/image-viewer/ImageViewerModel.tsx 6.42% <6.42%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@honkinglin honkinglin changed the title fix: 修复 onRemove 失效问题 fix(Upload): 修复 onRemove 失效问题 Aug 8, 2022
@uyarn uyarn merged commit 8b39ad4 into develop Aug 8, 2022
@uyarn uyarn deleted the fix/upload/remove branch August 8, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants