Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 优化 rangeInput icon 居中展示 #1447

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Sep 7, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(RangeInput): 优化 icon 居中展示的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1447 (4d07fd5) into develop (8a9ef3a) will increase coverage by 1.61%.
The diff coverage is 58.62%.

@@             Coverage Diff             @@
##           develop    #1447      +/-   ##
===========================================
+ Coverage    61.00%   62.62%   +1.61%     
===========================================
  Files         1030     1039       +9     
  Lines        17933    18005      +72     
  Branches      4121     4103      -18     
===========================================
+ Hits         10940    11275     +335     
+ Misses        6993     6730     -263     
Impacted Files Coverage Δ
src/_util/usePluginConfig.ts 0.00% <0.00%> (ø)
src/_util/useRipple.ts 26.38% <0.00%> (-0.38%) ⬇️
src/alert/_example/base.jsx 100.00% <ø> (ø)
src/alert/_example/operation.jsx 60.00% <0.00%> (-40.00%) ⬇️
src/cascader/_example/check-strictly.jsx 77.77% <ø> (ø)
src/cascader/_example/collapsed.jsx 87.50% <ø> (ø)
src/cascader/_example/disabled.jsx 100.00% <ø> (ø)
src/cascader/_example/filterable.jsx 77.77% <ø> (ø)
src/cascader/_example/keys.jsx 80.00% <ø> (ø)
src/cascader/_example/panel.jsx 80.00% <ø> (ø)
... and 126 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@uyarn uyarn merged commit e14da62 into develop Sep 13, 2022
@uyarn uyarn deleted the fix/range-input/icon branch September 13, 2022 02:48
@github-actions github-actions bot mentioned this pull request Sep 13, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants