Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 Image support ref props #2198

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: 🐛 Image support ref props #2198

merged 1 commit into from
May 8, 2023

Conversation

li-jia-nan
Copy link
Contributor

@li-jia-nan li-jia-nan commented May 8, 2023 •
edited by uyarn
Loading

Image support ref props

BREAKING CHANGE: 🧨 none

✅ Closes: #2193

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Image): 修复 Image 组件不支持 ref 的问题
  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@li-jia-nan
fix: 🐛 Image support ref props
6c525d8 
Image support ref props

BREAKING CHANGE: 🧨 none

✅ Closes: none
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

完成

@honkinglin
Copy link
Collaborator

关于defaultProps的改造可以参考这个pr
https://github.com/Tencent/tdesign-react/pull/2199/files

@honkinglin honkinglin merged commit 51b370b into Tencent:develop May 8, 2023
@li-jia-nan li-jia-nan deleted the image branch May 8, 2023 08:35
@github-actions github-actions bot mentioned this pull request May 10, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaishi chaishi chaishi left review comments

@honkinglin honkinglin honkinglin approved these changes

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

组件无法接收 ref 参数
3 participants
@li-jia-nan @honkinglin @chaishi