Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): create duplicated option with same label #2221

Merged
merged 1 commit into from
May 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/select/base/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ const Select = forwardRefWithStatics(
}
if (creatable && isFunction(onCreate)) {
if ((options as OptionsType).filter((option) => option.value === value).length === 0) {
onCreate(value);
onCreate(value as string); // 手动输入 此时为string
}
}
// 处理onChange回调中的selectedOptions参数
Expand Down Expand Up @@ -225,8 +225,8 @@ const Select = forwardRefWithStatics(
const upperValue = value.toUpperCase();
filteredOptions = tmpPropOptions.filter((option) => (option?.label || '').toUpperCase().includes(upperValue)); // 不区分大小写
}

if (creatable) {
const isSameLabelOptionExist = filteredOptions.find((option) => option.label === value);
if (creatable && !isSameLabelOptionExist) {
filteredOptions = filteredOptions.concat([{ label: value, value }]);
}
setCurrentOptions(filteredOptions);
Expand Down