Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taginput): add collapsedItems onClose #2881

Merged
merged 7 commits into from
May 8, 2024

Conversation

HaixingOoO
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. 统一 collapsedItems 的类型定义 (为什么只需要 value 和 onClose?其他属性都可以在外部拿到,且 onClose 仅需要 event 和 index 参数即可)
  2. 统一文档及示例交互形式。
  3. 涉及UI/交互变动需要有截图或 GIF。
image

📝 更新日志

  • fix(TagInput): 扩展 collapsedItems 的删除功能

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented May 7, 2024

完成

src/select/defaultProps.ts Outdated Show resolved Hide resolved
@uyarn
Copy link
Collaborator

uyarn commented May 7, 2024

尽量只加上对collapsedItems的API改动 其他的其他PR新增好点

@HaixingOoO
Copy link
Collaborator Author

HaixingOoO commented May 7, 2024

尽量只加上对collapsedItems的API改动 其他的其他PR新增好点

ok,我暂时先解决那个ci的问题,有哪些新增的功能,看缺什么我后面都加上好了

@uyarn
Copy link
Collaborator

uyarn commented May 7, 2024

尽量只加上对collapsedItems的API改动 其他的其他PR新增好点

ok,我暂时先解决那个ci的问题,有哪些新增的功能,看缺什么我后面都加上好了

报错看起来好熟悉 好像我在处理vue的PR tree-select也遇到了..

@HaixingOoO
Copy link
Collaborator Author

尽量只加上对collapsedItems的API改动 其他的其他PR新增好点

ok,我暂时先解决那个ci的问题,有哪些新增的功能,看缺什么我后面都加上好了

报错看起来好熟悉 好像我在处理vue的PR tree-select也遇到了..

哈哈哈,很熟悉是吧,类型的问题,现在是test的example的问题了

@HaixingOoO HaixingOoO requested a review from uyarn May 8, 2024 01:15
Co-authored-by: Haixing <65376724+HaixingOoO@users.noreply.github.com>
@uyarn
Copy link
Collaborator

uyarn commented May 8, 2024

TODO: 其他API补充 @HaixingOoO

@uyarn uyarn merged commit 40f5c30 into Tencent:develop May 8, 2024
5 checks passed
@HaixingOoO HaixingOoO deleted the feat/collapseditems branch May 8, 2024 04:02
This was referenced May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants