Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimePicker): timePicker confirm event is invalid #79

Merged
merged 4 commits into from
Dec 25, 2021

Conversation

yaogengzhu
Copy link
Contributor

#67

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2021

PR 预览产物在 https://preview-pr79-tdesign-react.surge.sh

return [dayjs().format(format), dayjs().format(format)];
}
return value;
}, [value, format]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useMemo 是否非必须?

return value;
}, [value, format]);

console.log(defaultValue);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

src/time-picker/panel/TimePickerPanel.tsx Show resolved Hide resolved
@uyarn uyarn merged commit 45bca64 into Tencent:develop Dec 25, 2021
uyarn pushed a commit that referenced this pull request Apr 18, 2022
* fix: timePicker confirm event is invalid

* fix: 优化

* fix: 优化

* fix: fixup type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants