Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 drawer cancelBtn 传入字符串无效 #860

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

honkinglin
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@honkinglin
Copy link
Collaborator Author

re #855

@codecov-commenter
Copy link

Codecov Report

Merging #860 (986a2ae) into develop (8fdcb64) will decrease coverage by 0.83%.
The diff coverage is 38.59%.

@@             Coverage Diff             @@
##           develop     #860      +/-   ##
===========================================
- Coverage    60.81%   59.98%   -0.84%     
===========================================
  Files          914      918       +4     
  Lines        15385    15774     +389     
  Branches      3467     3533      +66     
===========================================
+ Hits          9357     9462     +105     
- Misses        6028     6312     +284     
Impacted Files Coverage Δ
src/date-picker/defaultProps.ts 100.00% <ø> (ø)
src/form/FormItem.tsx 83.61% <ø> (+1.94%) ⬆️
src/form/defaultProps.ts 100.00% <ø> (ø)
src/input-number/StepHandler.tsx 72.72% <0.00%> (-2.28%) ⬇️
src/menu/MenuItem.tsx 61.11% <0.00%> (ø)
src/menu/_util/checkSubMenuChildExpanded.ts 0.00% <0.00%> (ø)
src/notification/_example/content.jsx 100.00% <ø> (ø)
src/notification/defaultProps.ts 100.00% <ø> (ø)
src/table/_example/drag-col-sort.jsx 66.66% <0.00%> (ø)
src/table/_example/drag-sort-handler.jsx 75.00% <0.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffaa31...986a2ae. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

完成

@uyarn uyarn merged commit 7f9a118 into develop Jun 9, 2022
@uyarn uyarn deleted the fix/drawer/cancel branch June 9, 2022 07:43
This was referenced Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants