Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): auto scroll when first mount #876

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jun 13, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(time-picker): 优化滚动方式 首次渲染滚动方式改为auto快速完成面板滚动

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #876 (b06a9b7) into develop (8fdcb64) will decrease coverage by 0.52%.
The diff coverage is 40.57%.

@@             Coverage Diff             @@
##           develop     #876      +/-   ##
===========================================
- Coverage    60.81%   60.29%   -0.53%     
===========================================
  Files          914      926      +12     
  Lines        15385    16074     +689     
  Branches      3467     3619     +152     
===========================================
+ Hits          9357     9692     +335     
- Misses        6028     6382     +354     
Impacted Files Coverage Δ
src/addon/Addon.tsx 0.00% <0.00%> (-92.31%) ⬇️
src/comment/Comment.tsx 95.45% <ø> (ø)
src/date-picker/DateRangePicker.tsx 10.79% <0.00%> (-0.08%) ⬇️
src/date-picker/base/Cell.tsx 20.00% <0.00%> (+13.33%) ⬆️
src/date-picker/base/Footer.tsx 73.33% <0.00%> (+59.04%) ⬆️
src/date-picker/base/Header.tsx 42.42% <ø> (+37.87%) ⬆️
src/date-picker/defaultProps.ts 100.00% <ø> (ø)
src/date-picker/hooks/useTableData.tsx 69.23% <ø> (ø)
src/date-picker/index.ts 100.00% <ø> (ø)
src/date-picker/panel/ExtraContent.tsx 100.00% <ø> (+100.00%) ⬆️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a747e...b06a9b7. Read the comment docs.

@github-actions
Copy link
Contributor

完成

@honkinglin honkinglin merged commit 8dc50a0 into develop Jun 13, 2022
@honkinglin honkinglin deleted the feat/timepicker-scroll-optimize branch June 13, 2022 10:16
@github-actions github-actions bot mentioned this pull request Jun 20, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants