Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): onChange callback param #951

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jun 24, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Select): onChange事件回调参数缺失

  • chore: 优化Select的Demo

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #951 (a18cd31) into develop (8fdcb64) will decrease coverage by 0.44%.
The diff coverage is 47.42%.

@@             Coverage Diff             @@
##           develop     #951      +/-   ##
===========================================
- Coverage    60.81%   60.37%   -0.45%     
===========================================
  Files          914      939      +25     
  Lines        15385    16491    +1106     
  Branches      3467     3736     +269     
===========================================
+ Hits          9357     9956     +599     
- Misses        6028     6535     +507     
Impacted Files Coverage Δ
src/_util/callBoth.ts 0.00% <ø> (ø)
src/_util/dom.ts 42.59% <0.00%> (+1.85%) ⬆️
src/alert/_example/base.jsx 100.00% <ø> (ø)
src/alert/_example/close.jsx 100.00% <ø> (ø)
src/alert/_example/icon.jsx 100.00% <ø> (ø)
src/alert/_example/operation.jsx 100.00% <ø> (ø)
src/alert/_example/swiper.jsx 100.00% <ø> (ø)
src/avatar/_example/adjust.jsx 100.00% <ø> (ø)
src/avatar/_example/base.jsx 100.00% <ø> (ø)
src/avatar/_example/group-cascading.jsx 100.00% <ø> (ø)
... and 316 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa1ebb...a18cd31. Read the comment docs.

@honkinglin honkinglin merged commit 025a05d into develop Jun 24, 2022
@honkinglin honkinglin deleted the fix/select-context branch June 24, 2022 06:19
@uyarn
Copy link
Collaborator Author

uyarn commented Jun 24, 2022

break-line后multiple换行问题另提PR处理

@github-actions github-actions bot mentioned this pull request Jun 27, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants