Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): fix slider inputNumber decrease value bug #1136

Merged

Conversation

ChrisLee0211
Copy link
Contributor

@ChrisLee0211 ChrisLee0211 commented Jul 2, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

问题:使用数字输入框的情况下,同时传入range和min或max其中之一的属性,手动输入某个值会导致渲染出NaN
原因:当存在min或max时,进行删减操作会导致inputNumber组件的onChange函数回传undefined值
解决办法:对于传入inputNumber的onChange函数进行一层格式化封装避免非数字回传值更新

📝 更新日志

  • fix(Slider): 使用 InputNumber 时在使用 range 属性情况下传入 minmax 会导致手动输入显示NaN问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

完成

@PengYYYYY PengYYYYY merged commit 56205a0 into Tencent:develop Jul 2, 2022
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
16 tasks
@ChrisLee0211 ChrisLee0211 deleted the fix/slider-inputNumber-decrease-bug branch August 20, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants