Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): breakline logic #1143

Merged
merged 2 commits into from
Jul 4, 2022
Merged

fix(Select): breakline logic #1143

merged 2 commits into from
Jul 4, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jul 4, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

关联PR Tencent/tdesign-common#598

修复Select换行过早的问题

Select此前即使改成breakline multiple下换行的表现还是和原有的select表现有不同
表现为在

  1. 没有开启过滤时仍然占行
  2. 有足够空间的时候仍然提前换行占满一行

对于问题1 增加非对外暴露API showInput 由tagInput透传
对于问题2 增加非对外暴露API keepWrapperWidth 因为需要同时利用autoWidth 让input标签宽度自适应 又需要保留select/tag-input默认的宽度

修复前后对比

before.mp4
Jun-28-2022.11-08-39.mp4

📝 更新日志

  • fix(Select): 修复多选下换行提前占满一行的问题
  • fix(Select): 修复input高度height 100% 导致换行高度异常的问题
  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022

完成

@PengYYYYY PengYYYYY merged commit 05ed2fa into develop Jul 4, 2022
@PengYYYYY PengYYYYY deleted the fix/select-breakline branch July 4, 2022 04:33
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants