Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(image-viewer): 新增image-viewer组件 #1516

Merged
merged 7 commits into from
Sep 4, 2022
Merged

feat(image-viewer): 新增image-viewer组件 #1516

merged 7 commits into from
Sep 4, 2022

Conversation

sinbadmaster
Copy link
Contributor

@sinbadmaster sinbadmaster commented Aug 26, 2022 •
edited by PengYYYYY
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1402

💡 需求背景和解决方案

📝 更新日志

  • feat(ImageViewer): 增加 ImageViewer 组件 (issue 1402)

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022 •
edited
Loading

完成

@sinbadmaster sinbadmaster force-pushed the feat/imageViewer branch 2 times, most recently from 3af92d4 to 0ca60ed Compare August 27, 2022 01:03
@PengYYYYY
Copy link
Collaborator

PengYYYYY commented Aug 27, 2022 •
edited
Loading

预览图片时，双指进行缩放操作会有表现异常

PengYYYYY
PengYYYYY reviewed Aug 27, 2022
View reviewed changes
src/image-viewer/image-viewer.tsx Outdated Show resolved Hide resolved
test/unit/image-viewer/__snapshots__/demo.test.js.snap Outdated Show resolved Hide resolved
test/unit/image-viewer/index.test.js Outdated Show resolved Hide resolved
@sinbadmaster
Copy link
Contributor Author

预览图片时，双指进行缩放操作会有表现异常

我看看

@sinbadmaster sinbadmaster force-pushed the feat/imageViewer branch 2 times, most recently from f35dd25 to eea371f Compare September 2, 2022 01:34
@PengYYYYY
Copy link
Collaborator

Screen.Recording.2022-09-03.at.16.44.08.mov

这个交互背景应该不能方法，再看看

PengYYYYY
PengYYYYY reviewed Sep 3, 2022
View reviewed changes
src/image-viewer/base/ImageItem.tsx Outdated Show resolved Hide resolved
src/image-viewer/base/ImageModalIcon.tsx Outdated Show resolved Hide resolved
src/image-viewer/base/ImageViewerUtils.tsx Outdated Show resolved Hide resolved
src/image-viewer/base/ImageViewerModal.tsx Outdated Show resolved Hide resolved
@PengYYYYY PengYYYYY merged commit f30dce7 into Tencent:develop Sep 4, 2022
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Merged
15 tasks
@sinbadmaster sinbadmaster deleted the feat/imageViewer branch May 22, 2023 07:05
@sinbadmaster sinbadmaster restored the feat/imageViewer branch May 22, 2023 07:06
@sinbadmaster sinbadmaster deleted the feat/imageViewer branch May 22, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinbadmaster @PengYYYYY