Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): 修复全选时可以选中已禁用选项的问题 #1554

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

RayJason
Copy link
Contributor

@RayJason RayJason commented Aug 31, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Vue 3: #1549
Vue 2: Tencent/tdesign-vue#1424

💡 需求背景和解决方案

问题原因:
多选的判断没有考虑disabled的状态。
解决方案:
排除不计入全选计算的option。

const isCheckAll = computed<boolean>(() => {
+ const excludeCount = optionList.value.filter((item) => item.disabled || item.checkAll).length;
  if (isArray(innerValue.value) && innerValue.value.length !== optionList.value.length - excludeCount) return false;
  return intersectionLen.value === optionList.value.length - excludeCount;
});

image

📝 更新日志

  • fix(checkbox): 修复全选时可以选中已禁用选项的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@RayJason RayJason changed the title fix: 修复checkbox可以选中禁用的选项(#1549) fix: 修复checkbox全选时选中已禁用的选项(#1549) Aug 31, 2022
@RayJason RayJason changed the title fix: 修复checkbox全选时选中已禁用的选项(#1549) fix(checkbox): 修复全选时可以选中已禁用选项的问题 Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

完成

@PengYYYYY
Copy link
Collaborator

处理一下单元测试

@PengYYYYY PengYYYYY merged commit 28386d2 into Tencent:develop Sep 1, 2022
@RayJason RayJason deleted the rayjason/fix-checkbox-group branch September 1, 2022 03:16
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants