Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tree): 修复Tree active事件中actived值相反(#3110) #3134

Merged
merged 3 commits into from
Jul 25, 2023
Merged

fix(tree): 修复Tree active事件中actived值相反(#3110) #3134

merged 3 commits into from
Jul 25, 2023

Conversation

gaoachao
Copy link
Contributor

@gaoachao gaoachao commented Jul 21, 2023 •
edited
Loading

closed #3110

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#3110

💡 需求背景和解决方案

  1. 目前actived的值与实际情况相反。
  2. 解决方案：在传入ctx的时候做一遍判断，看当前节点是否在actived的数组中，然后调整ctx.node.actived的值。

📝 更新日志

  • fix(tree): 修复Tree Events - active 事件中，参数 context 中 actived 值和实际状态相反

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023 •
edited
Loading

完成

PengYYYYY
PengYYYYY reviewed Jul 25, 2023
View reviewed changes
src/tree/useTree.tsx Outdated Show resolved Hide resolved
@PengYYYYY PengYYYYY merged commit 12486ae into Tencent:develop Jul 25, 2023
5 checks passed
This was referenced Jul 26, 2023
Closed
Merged
uyarn added a commit that referenced this pull request Jul 27, 2023
@uyarn
Revert "fix(tree): 修复Tree active事件中actived值相反(#3110) (#3134)"
947bbe3 
This reverts commit 12486ae.
@uyarn uyarn mentioned this pull request Jul 27, 2023
Merged
PengYYYYY pushed a commit that referenced this pull request Jul 27, 2023
@uyarn
Revert "fix(tree): 修复Tree active事件中actived值相反(#3110) (#3134)" (#3159)
928c63c 
This reverts commit 12486ae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tree] Tree Events - active 事件中，参数 context 中 actived 值和实际状态相反
2 participants
@gaoachao @PengYYYYY