Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(descriptions): vertical layout should reset span to 1 #4656

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

zhangpaopao0609
Copy link
Collaborator

@zhangpaopao0609 zhangpaopao0609 commented Oct 16, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复

🔗 相关 Issue

#4655

💡 需求背景和解决方案

shown in issue above.

  1. vertical layout should ignore span
  2. if span is greater than column, it should reset it to the number of cloumn

📝 更新日志

  • fix(Descriptions): ignore span when layout is vertical and reset span to column when span greater than column

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Oct 16, 2024

完成

@zhangpaopao0609
Copy link
Collaborator Author

还有一个遗留的问题�,有同学在处理,要是没有处理的话这里记得处理。
问题:https://stackblitz.com/edit/nkkept?file=package.json,src%2Fdemo.vue,descriptions 设置 layout="vertical" 属性,不可以使用label 插槽

修复方式:
针对这个问题的话

  1. 直接 props 可选处理一下吧
  2. 然后要是能把类型加上的话也加一下
  3. 示例也加一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant