-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refact menu by popup #2461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyarn
reviewed
May 30, 2023
uyarn
approved these changes
Jun 2, 2023
Merged
KMethod
pushed a commit
to KMethod/tdesign-vue
that referenced
this pull request
Aug 25, 2023
* feat: refact menu by popup * fix: head menu popup position * fix: menu popup mouse enter bug in * fix: tooltip pop menu level logic * test: update snapshot * feat: render by <a> in href menu item * feat: scroll style move to less * test: update snapshot * feat: update common * feat: update common * feat: update common * fix: head popup menu position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
Tencent/tdesign-vue-next#1671
💡 需求背景和解决方案
修复菜单层级判断逻辑,只有在一级菜单收起时展示 tooltip
在传入 href 时使用 标签渲染菜单内容 DOM,与 vue-next 实现保持一致:
📝 更新日志
refact(Menu): 使用 Popup 重构 Menu 弹出菜单实现
fix(Menu): 修复收起菜单时超出内容无法滚动的问题 [Menu] 收起时菜单超出屏幕时样式有问题且无法滚动 #2435
fix(Menu): 修复侧边导航菜单,次级弹出菜单也会展示 Tooltip 的问题
feat(Menu): 设置
href
时使用 标签渲染菜单项 [Menu][MenuItem] 如果存在链接参数,默认使用标签<a>
tdesign-vue-next#1671本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单