Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refact menu by popup #2461

Merged
merged 15 commits into from
Jun 2, 2023
Merged

feat: refact menu by popup #2461

merged 15 commits into from
Jun 2, 2023

Conversation

xiaosansiji
Copy link
Collaborator

@xiaosansiji xiaosansiji commented May 30, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Tencent/tdesign-vue-next#1671

💡 需求背景和解决方案

image
修复菜单层级判断逻辑,只有在一级菜单收起时展示 tooltip

在传入 href 时使用 标签渲染菜单内容 DOM,与 vue-next 实现保持一致:
image

📝 更新日志

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023

完成

src/menu/submenu.tsx Outdated Show resolved Hide resolved
@uyarn uyarn changed the title [WIP]feat: refact menu by popup feat: refact menu by popup May 30, 2023
@uyarn uyarn merged commit a85ac11 into develop Jun 2, 2023
@uyarn uyarn deleted the refact/menu-popup branch June 2, 2023 02:55
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
KMethod pushed a commit to KMethod/tdesign-vue that referenced this pull request Aug 25, 2023
* feat: refact menu by popup

* fix: head menu popup position

* fix: menu popup mouse enter bug in

* fix: tooltip pop menu level logic

* test: update snapshot

* feat: render by <a> in href menu item

* feat: scroll style move to less

* test: update snapshot

* feat: update common

* feat: update common

* feat: update common

* fix: head popup menu position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants