fix(menu): fix submenu parent item active status on mounted #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyarn
requested review from
chaishi,
xiaosansiji,
maoyiluo,
liweijie0812 and
LoopZhou
as code owners
|
|
chaishi
reviewed
Oct 12, 2024
src/menu/submenu.tsx
Outdated
|
|
||
| export default defineComponent({ | ||
| name: 'TSubmenu', | ||
| name: submenuName, |
There was a problem hiding this comment.
这里的名字改的我有点慌，曾经这里也写的是变量，但是打包后，失效了
然后有一次，就全部重新改成字符串了
There was a problem hiding this comment.
这个地方还是字符串没变 是方便后面取该组件使用
chaishi
reviewed
Oct 12, 2024
| break; | ||
| } | ||
| node = node?.parent; | ||
| } | ||
| const activeValue = menu?.activeValue.value; | ||
| if (activeValue !== props.value && mode.value === 'popup') { |
There was a problem hiding this comment.
这里的代码板块理解过于复杂，建议定义单独的函数分别计算
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
修复前
修复后
MenuItem在初始化时会被加入vMenu的上下文中，由于此场景下，选中菜单在一开始并没有被初始化，所以需要手动加入vMenu中📝 更新日志
fix(Menu): 修复
mode为popup的多级菜单场景下，选中菜单项在叶子节点时父级菜单初始化没有正确展示高亮效果的缺陷本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单