Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 优化 form 样式 & 默认渲染 extra 节点 #730

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

honkinglin
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

Size Change: -243 B (0%)

Total Size: 617 kB

Filename Size Change
./dist/tdesign.js 344 kB -570 B (0%)
./dist/tdesign.min.js 197 kB +327 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 40.5 kB
./dist/tdesign.min.css 35.8 kB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2022

完成

@github-actions
Copy link
Contributor

Size Change: -243 B (0%)

Total Size: 617 kB

Filename Size Change
./dist/tdesign.js 344 kB -570 B (0%)
./dist/tdesign.min.js 197 kB +327 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 40.5 kB
./dist/tdesign.min.css 35.8 kB

@codecov-commenter
Copy link

Codecov Report

Merging #730 (a3d9ad6) into develop (a0db0df) will increase coverage by 0.08%.
The diff coverage is 72.72%.

❗ Current head a3d9ad6 differs from pull request most recent head eb056f7. Consider uploading reports for the commit eb056f7 to get more accurate results

@@             Coverage Diff             @@
##           develop     #730      +/-   ##
===========================================
+ Coverage    57.56%   57.64%   +0.08%     
===========================================
  Files          346      346              
  Lines        12828    12829       +1     
  Branches      2405     2403       -2     
===========================================
+ Hits          7384     7395      +11     
+ Misses        5200     5189      -11     
- Partials       244      245       +1     
Impacted Files Coverage Δ
src/form/const.ts 100.00% <ø> (ø)
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/form/form-item.tsx 43.33% <25.00%> (+0.27%) ⬆️
src/utils/withInstall.ts 87.50% <33.33%> (-12.50%) ⬇️
src/index.ts 100.00% <100.00%> (ø)
src/slider/slider-button.tsx 25.00% <100.00%> (+0.90%) ⬆️
src/slider/slider.tsx 59.29% <100.00%> (+5.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d309b27...eb056f7. Read the comment docs.

@xiaosansiji xiaosansiji merged commit 2674dac into develop Apr 12, 2022
@xiaosansiji xiaosansiji deleted the feat/form/style branch April 12, 2022 09:10
import * as components from './components';

function install(Vue: VueConstructor, config?: object) {
Vue.use(VueCompositionAPI);
Copy link
Contributor

@cong-min cong-min Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里希望能像其他地方一样加一下判断:if (Vue._installedPlugins.indexOf(VueCompositionAPI) === -1) Vue.use(VueCompositionAPI);
现在不判断会和其他库产生冲突导致报错:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants