Add support for UNIX Socket in VAULT_ADDR and test cases #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could cause issues in the testing chain -- it seems necessary on CentOS 7, but it's not obvious that it would be without issues on existing installations. (Adding `selinux` in the `test-requirements.txt` was not sufficient to suppress the "missing `python-libselinux` bindings" error I encountered.)
This tests for TerryHowe#319.
Vault Agent gives us the capability to listen on a UNIX socket for connections. This is super handy for environments relying on UNIX permissions for application access, whereas a TCP listener on localhost doesn't give us the same kind of control. Support for this isn't baked directly into HVAC, but there is a mechanism for clients to pass in a requests-compatible interface. In lieu of direct support in HVAC, this commit implements a special construction in this collection for handling the UNIX Socket case. (Basically, if 'unix://' in vault_addr, then handle the "special case" until HVAC adds direct support.)
|
The tests are now failing in the CI environment, not too surprisingly, because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve #319 , which raises that HVAC does not directly support UNIX sockets, but has a clean workaround, by using
requests_unixsocketto open aSessionon the socket ahead of constructing the HVACClient. This pull request implements that change in fcac9cc.All other commits are in support of the testing environment (to which I had to add Vault Agent, in order to support the test case) and the test case itself.
Please note, the new test requires
requests_unixsocketto be available on the execution host, but that import is not made unless aVAULT_ADDRwithunixin the scheme is supplied.