Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin OCMock version to 3.4.1 because 3.4.2 has issues #1038

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

Adlai-Holler
Copy link
Member

With any luck this will fix the CI.

@ghost
Copy link

ghost commented Jul 18, 2018

🚫 CI failed with log

@Adlai-Holler
Copy link
Member Author

OK the unit tests passed 🎉 The Weaver example failed to build because Weaver relies on some API that I changed in #1030 . I'll put that back in a follow up diff in a few minutes after I land this one.

@Adlai-Holler Adlai-Holler merged commit 9958aac into master Jul 18, 2018
@Adlai-Holler Adlai-Holler deleted the AHPinOCMockVersion branch July 18, 2018 02:51
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
bolsinga pushed a commit that referenced this pull request May 21, 2020
- The issues in #1038 are not explained.
- In `ASCollectionViewTests` do not mock every `collectionViewLayout`, only do it for the test that requires it. In addition, call `-stopMocking` when done. OCMock 3.6 found this code using stuff after it should have been.
- 5c42bb4 says the layer tests are not typically run, but they are in the project. That diff refers to ASUIViewTests being skipped, but those tests do not exist. So I've just disabled them in this diff. It is not clear how they ever worked.
@bolsinga bolsinga mentioned this pull request May 21, 2020
bolsinga pushed a commit that referenced this pull request May 22, 2020
- The issues in #1038 are not explained.
- In `ASCollectionViewTests` do not mock every `collectionViewLayout`, only do it for the test that requires it. In addition, call `-stopMocking` when done. OCMock 3.6 found this code using stuff after it should have been.
- 5c42bb4 says the layer tests are not typically run, but they are in the project. That diff refers to ASUIViewTests being skipped, but those tests do not exist. So I've just disabled them in this diff. It is not clear how they ever worked.
rcancro pushed a commit to rcancro/Texture that referenced this pull request May 28, 2020
- The issues in TextureGroup#1038 are not explained.
- In `ASCollectionViewTests` do not mock every `collectionViewLayout`, only do it for the test that requires it. In addition, call `-stopMocking` when done. OCMock 3.6 found this code using stuff after it should have been.
- 5c42bb4 says the layer tests are not typically run, but they are in the project. That diff refers to ASUIViewTests being skipped, but those tests do not exist. So I've just disabled them in this diff. It is not clear how they ever worked.
piotrdebosz pushed a commit to getstoryteller/Texture that referenced this pull request Mar 1, 2021
- The issues in TextureGroup#1038 are not explained.
- In `ASCollectionViewTests` do not mock every `collectionViewLayout`, only do it for the test that requires it. In addition, call `-stopMocking` when done. OCMock 3.6 found this code using stuff after it should have been.
- 5c42bb4 says the layer tests are not typically run, but they are in the project. That diff refers to ASUIViewTests being skipped, but those tests do not exist. So I've just disabled them in this diff. It is not clear how they ever worked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants