Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added first solution to problem 135 #4035

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Added first solution to problem 135 #4035

merged 1 commit into from
Dec 19, 2020

Conversation

sharmapulkit04
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Dec 14, 2020
@ghost ghost mentioned this pull request Dec 14, 2020
Closed
14 tasks
poyea
poyea approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 17, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Dec 18, 2020
dhruvmanila
dhruvmanila requested changes Dec 18, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor tweak and this is good to go!

project_euler/problem_135/sol1.py Outdated Show resolved Hide resolved
@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Dec 18, 2020
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Dec 18, 2020
dhruvmanila
dhruvmanila approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 19, 2020
@dhruvmanila dhruvmanila merged commit 00f22a9 into TheAlgorithms:master Dec 19, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@sharmapulkit04 @stokhos
Add solution for Project Euler problem 135 (TheAlgorithms#4035)
c0a3beb
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@sharmapulkit04 @peRFectBeliever
Add solution for Project Euler problem 135 (TheAlgorithms#4035)
e6a812b
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@sharmapulkit04
Add solution for Project Euler problem 135 (TheAlgorithms#4035)
d34e6d6
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@sharmapulkit04 @shermanhui
Add solution for Project Euler problem 135 (TheAlgorithms#4035)
61cac45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

@dhruvmanila dhruvmanila

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharmapulkit04 @poyea @dhruvmanila