Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure API_VERSION is attached to request url. Fixes #64 #70

Merged
merged 5 commits into from
Oct 25, 2018
Merged

Ensure API_VERSION is attached to request url. Fixes #64 #70

merged 5 commits into from
Oct 25, 2018

Conversation

arueckauer
Copy link
Contributor

No description provided.

hajekj
hajekj requested changes Oct 25, 2018
View reviewed changes
Copy link
Member

@hajekj hajekj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API_VERSION should be only appended when we are caling Windows Azure AD Graph - graph.windows.net, it shouldn't be appended to any other API calls. Do you think you could fix that please?

@arueckauer
Copy link
Contributor Author

Thanks for the hint. Changes are made as discussed.

@hajekj hajekj merged commit d3b04a6 into TheNetworg:master Oct 25, 2018
@hajekj
Copy link
Member

hajekj commented Oct 25, 2018

Awesome, I have merged this, thanks for the PR!

@hajekj hajekj mentioned this pull request Oct 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajekj hajekj hajekj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arueckauer @hajekj