restructured Azure Provider to not require custom AccessToken #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to create AzureResourceOwner
|
Thank you for the PR, I have got to review it so late, I am sorry. I have to evaluate the effect of the changes. I don't think I will be releasing the v2.0.0 branch as v2, instead, I will continue with change #76 in master. And I believe we could squeeze this one in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ResourceOwner related functions in Azure Provider to remove the need for injecting the Provider into the AccessToken, and removes the need for a custom AccessToken.
This does introduce a breaking change if users relied upon getIdTokenClaims() on AccessToken, so may be best committed to v2.0.0 branch (although I have not tested against that branch).