Improvements to getJwtVerificationKeys #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2019 11:55
… from x5c in Azure::getJwtVerificationKeys().
… a whole certificate.
hajekj
reviewed
Jan 23, 2019
src/Provider/Azure.php
Outdated
| $key .= PHP_EOL . '-----END CERTIFICATE-----'; | ||
| $keys[$keyinfo['kid']] = $key; | ||
| $cert = | ||
| "-----BEGIN CERTIFICATE-----\r\n" |
There was a problem hiding this comment.
Shouldn't there be PHP_EOL instead? Same goes for line 251.
…tJwtVerificationKeys.
|
PR updated to use PHP_EOL. |
|
I run it inside an official PHP docker image. I have not tested it on Windows yet. |
|
Merged, thanks for the PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves getJwtVerificationKeys in two ways: