Provide better support for v2.0 OpenID Config #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getTenantDetails` method harded the url rather than allowing customization. This update utilizes the `urlLogin` parameter (which can either be the legacy login.windows.net or login.microsoftonline.com), introduces constants (as defined in PR TheNetworg#76) and then utilizes those to build the URI to receive the openid-configuration data. This will resolve issues with invalid issuer errors while creating the `AccessToken` when utilizing the openid auth/token endpoints. Fixes TheNetworg#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getTenantDetailsmethod harded the url rather than allowingcustomization. This update utilizes the
urlLoginparameter (which caneither be the legacy login.windows.net or login.microsoftonline.com),
introduces constants (as defined in PR #76) and then utilizes those to
build the URI to receive the openid-configuration data.
This will resolve issues with invalid issuer errors while creating the
AccessTokenwhen utilizing the openid auth/token endpoints.Fixes #78