Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error description to message to improve exception quality #99

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

JoshuaBehrens
Copy link
Contributor

In case of a misconfiguration one does only get an "invalid_client" as messages which can be anything regarding to Microsoft.

With the description in addition you can get helpful messages like:

invalid_client
AADSTS50011: The reply URL specified in the request does not match the reply URLs configured for the application: '12345678-1234-1234-1234-1234567890ab'.
  Trace ID: 12345678-1234-1234-1234-1234567890ab
  Correlation ID: 12345678-1234-1234-1234-1234567890ab
  Timestamp: 2020-01-07 10:00:00Z

@hajekj hajekj merged commit 32eb3f4 into TheNetworg:master Jan 7, 2020
@hajekj
Copy link
Member

hajekj commented Jan 7, 2020

Awesome! Thanks for the PR! This is now merged to master!

@JoshuaBehrens
Copy link
Contributor Author

Thanks for merging this. So I can update my application 👍

@JoshuaBehrens JoshuaBehrens deleted the patch-1 branch January 26, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants