Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid/03-grid-layout-3/solution/solution.css : the grid-template-row command seems unnecessary #187

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

mengxihe
Copy link
Contributor

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check

Complete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:

  • I have ensured that the TOP solution files match the Desired Outcome image

1. Because:

Closes #XXXXX

2. This PR:

3. Additional Information:

@dm-murphy dm-murphy added the Status: Under Review This issue/PR is being reviewed by at least one maintainer label Jul 7, 2022
@dm-murphy dm-murphy self-requested a review July 7, 2022 17:45
Copy link
Member

@dm-murphy dm-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mengxihe 👋

Good catch and thanks for your contribution! 🙏

@dm-murphy dm-murphy merged commit 2085586 into TheOdinProject:main Jul 12, 2022
venegas55 pushed a commit to venegas55/css-exercises that referenced this pull request May 10, 2023
grid/03-grid-layout-3/solution/solution.css : the grid-template-row command seems unnecessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Under Review This issue/PR is being reviewed by at least one maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants