-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction To React Testing: Remove redundant section #27565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this done, @nikitarevenco
2 things:
- Could you get the linting errors in this file fixed up? I'm sure you'll have no troubles doing this. For the fenced code-block language,
bash
would be most suitable, and the link fragment that is currently set to#setting-up
can be changed to#setting-up-a-react-testing-environment
. - At the end of line 126 ("The tests speak for themselves..."), could you append the following sentence?
Notice that the callback function for the second test is an async one, as we need this in order to
await user.click()
.
Even though we don't really need to go through the v14.0.0 changes specifically anymore, I still think it'll be good to bring attention to that callback being an async one as a little reminder just in case.
Yeah, I agree that needed some clarification. I've made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the backtick thing then otherwise this should be good to merge 🚀
Because
There is a section that was more relevant when React course first released, and relevant now. I've removed it
This PR
Issue
Closes #27561
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section