Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction To React Testing: Remove redundant section #27565

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

nikitarevenco
Copy link
Contributor

Because

There is a section that was more relevant when React course first released, and relevant now. I've removed it

This PR

  • Removes unnecessary section

Issue

Closes #27561

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@nikitarevenco nikitarevenco changed the title Introduction To React Testing Introduction To React Testing: Remove redundant section Mar 7, 2024
@github-actions github-actions bot added the Content: React Involves the React course label Mar 7, 2024
@MaoShizhong MaoShizhong self-assigned this Mar 7, 2024
@MaoShizhong MaoShizhong self-requested a review March 7, 2024 20:23
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done, @nikitarevenco

2 things:

  1. Could you get the linting errors in this file fixed up? I'm sure you'll have no troubles doing this. For the fenced code-block language, bash would be most suitable, and the link fragment that is currently set to #setting-up can be changed to #setting-up-a-react-testing-environment.
  2. At the end of line 126 ("The tests speak for themselves..."), could you append the following sentence?

Notice that the callback function for the second test is an async one, as we need this in order to await user.click().

Even though we don't really need to go through the v14.0.0 changes specifically anymore, I still think it'll be good to bring attention to that callback being an async one as a little reminder just in case.

@nikitarevenco
Copy link
Contributor Author

Thanks for getting this done, @nikitarevenco

2 things:

  1. Could you get the linting errors in this file fixed up? I'm sure you'll have no troubles doing this. For the fenced code-block language, bash would be most suitable, and the link fragment that is currently set to #setting-up can be changed to #setting-up-a-react-testing-environment.
  2. At the end of line 126 ("The tests speak for themselves..."), could you append the following sentence?

Notice that the callback function for the second test is an async one, as we need this in order to await user.click().

Even though we don't really need to go through the v14.0.0 changes specifically anymore, I still think it'll be good to bring attention to that callback being an async one as a little reminder just in case.

Yeah, I agree that needed some clarification. I've made the changes

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the backtick thing then otherwise this should be good to merge 🚀

react/react_testing/introduction_to_react_testing.md Outdated Show resolved Hide resolved
@MaoShizhong MaoShizhong merged commit 4e2a1d9 into TheOdinProject:main Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduction To React Testing: Remove Section on synchronous userEvent.click method
2 participants