Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Basics: Add image that describes how parameters are passed to a function and returned from it #27586

Merged
merged 10 commits into from
Mar 17, 2024

Conversation

nikitarevenco
Copy link
Contributor

@nikitarevenco nikitarevenco commented Mar 9, 2024

Because

Improved formatting of lesson also; moved everything relevant to assignment and added a lot of line breaks that increase readability

This PR

Issue

Closes #27539

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Mar 9, 2024
@JoshDevHub JoshDevHub requested review from a team and 01zulfi and removed request for a team March 10, 2024 16:35
@JoshDevHub JoshDevHub removed the request for review from 01zulfi March 10, 2024 16:36
@JoshDevHub JoshDevHub self-requested a review March 10, 2024 16:37
@JoshDevHub JoshDevHub self-assigned this Mar 10, 2024
Copy link
Contributor

@JoshDevHub JoshDevHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like a lot of your changes and reorganizations here. Nice work.

Just a few fixes for trailing spaces on certain lines and one nitpick about one of the links. Everything else looks good though.

foundations/javascript_basics/function_basics.md Outdated Show resolved Hide resolved
foundations/javascript_basics/function_basics.md Outdated Show resolved Hide resolved
foundations/javascript_basics/function_basics.md Outdated Show resolved Hide resolved
foundations/javascript_basics/function_basics.md Outdated Show resolved Hide resolved
foundations/javascript_basics/function_basics.md Outdated Show resolved Hide resolved
nikitarevenco and others added 6 commits March 17, 2024 11:06
Co-authored-by: Josh Smith <jmsmith1018@gmail.com>
Co-authored-by: Josh Smith <jmsmith1018@gmail.com>
Co-authored-by: Josh Smith <jmsmith1018@gmail.com>
Co-authored-by: Josh Smith <jmsmith1018@gmail.com>
Co-authored-by: Josh Smith <jmsmith1018@gmail.com>
@JoshDevHub JoshDevHub merged commit 9efa38a into TheOdinProject:main Mar 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function basics: add image showing what parameters and arguments stand for
3 participants