-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update how_this_course_will_work.md #27866
base: main
Are you sure you want to change the base?
Conversation
Making the final message more exciting, adding an exclamation point! I believe removing ' and adding !!! will get the reader more excited to start learning React.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reactin'
is barely a word, reactin
on the other hand, is a non-steroidal anti-inflammatory.
Joking aside, I think if we're going to keep this text as a heading, (which I'm leaning towards removing or changing now that it's brought up...) we probably want to keep the apostrophe and stick to a single exclamation mark.
@xPedroNoronhax are you willing to make the suggested change? |
@@ -12,4 +12,4 @@ As always, we'll preface this by saying that learning a new technology can be a | |||
|
|||
Now then, | |||
|
|||
### Let’s start Reactin’ | |||
### Let’s start Reactin!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Let’s start Reactin!! | |
### Let’s start Reactin'! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a suggestion as requested by @xandora
I'm of the same opinion.
You can change this file locally and commit the change, or commit my suggestion for the same result and re-request a review :)
Making the final message more exciting, adding an exclamation point! I believe removing ' and adding !!! will get the reader more excited to start learning React.
Because
Making the final message more exciting, adding an exclamation point!
I believe removing ' and adding !!! will get the reader more excited to start learning React.
##This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section