Add fiction list filter (PP-1110)

[jonathangreen]

Description

Add a new filter to the list search that allows filtering on fiction and nonfiction. If the new filter is selected, the input is replaced with a select list, so that the values you can enter are restricted to fiction and nonfiction since these are the only two valid values for the field.

Any feedback on this one would be great. It does accomplish what is asked in the ticket, and I think it works from the user perspective, in my testing at least. I only know enough to be dangerous about react though, so there may be better ways to accomplish what I'm doing here.

Motivation and Context

Would like to be able to filter custom lists by fiction status. See PP-1110.

How Has This Been Tested?

Tested against gorgon running the admin interface locally with the blackstone collection.

Checklist:

• I have updated the documentation accordingly.
• All new and existing tests passed.

[tdilauro]

This looks pretty good. There is one potential sneaky bug related to restricting filterOps when a new filterKey is selected.

[tdilauro]

Minor: This is fine and will work; but we could simplify it. Since there's only one statement in the filter function, we can drop the braces and the return. And because there's only one parameter, we can drop the parens. If we don't mind including null with the already-present undefined, we can also drop the comparison.

  const selectedFieldOperators = selectedField.operators
    ? operators.filter(op => selectedField.operators.includes(op.value))
    : operators;

[jonathangreen]

That it much more readable, thanks! Eslint doesn't like dropping the braces around op, so I added those back in, but otherwise I made this change.

[tdilauro]

There could be a problem here. This PR is introducing the potential for a reduced set of operators, so we'll also need to ensure that we've got a valid operator for the newly current field. Ideally, we'd only change the filterOp if the current one is not supported.

It would be useful to add a test simulating going from an op on a field with broader set ops to a field that doesn't support that op, then adding the filter, and finally verifying that the key, value, and op are as expected.

[jonathangreen]

Good catch! Thank you, totally missed this one.

[jonathangreen]

@tdilauro I think this is ready for another review. I added another test and addressed both your code review comments.

[tdilauro]

Looks good! 🎉